Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-couple JSONSchema and Protobuf implementations from Avro #633

Open
aiven-anton opened this issue May 31, 2023 · 0 comments
Open

De-couple JSONSchema and Protobuf implementations from Avro #633

aiven-anton opened this issue May 31, 2023 · 0 comments

Comments

@aiven-anton
Copy link
Contributor

The Protobuf and JSONSchema implementations currently have dependencies on Avro's SchemaCompatibilityResult. These implementations should be independent from each other. If we need a container to carry compatibility check results, we should define our own and not piggy-back on Avro's implementation.

Other than best-practice, this also has implications on type-checking, since we pass in objects of the wrong type to the fields of Avro-specific entities. In this example, we pass in list[str] for incompatibilities, where a avro.compatibility.SchemaIncompatibilityType is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant