Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce boilerplate in tests #89

Open
1 task
mdedetrich opened this issue Jan 24, 2022 · 0 comments
Open
1 task

Reduce boilerplate in tests #89

mdedetrich opened this issue Jan 24, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@mdedetrich
Copy link
Collaborator

mdedetrich commented Jan 24, 2022 •
edited

What is currently missing?

The current tests, particularly RealS3BackupClientSpec have quite a bit of boilerplate code which can be reduced with basic refactoring.

How could this be improved?

Refactoring out common code in the tests with function should alleviate most of the boilerplate.

Is this a feature you would work on yourself?

  • I plan to open a pull request for this feature
@mdedetrich mdedetrich added the good first issue Good for newcomers label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdedetrich