Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reference.conf environment variables to cli modules #151

Open
1 task
mdedetrich opened this issue Mar 17, 2022 · 0 comments
Open
1 task

Move reference.conf environment variables to cli modules #151

mdedetrich opened this issue Mar 17, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@mdedetrich
Copy link
Collaborator

Currently environment variable overrides are defined in reference.conf in core modules, i.e. https://github.com/aiven/guardian-for-apache-kafka/blob/main/core-backup/src/main/resources/reference.conf#L1-L30 . When thinking about this, ideally they should be moved to the equivalent cli porject as application.conf files since the environment variables are only relevant when you actually run your application.

Furthermore if someone uses Guardian core modules as a library the user of that library may not want to expose those environment variables under these name/s (or even at all). This can also help alleviate #91 since we can encapsulate any such changes in the cli modules and leave the core Guardian modules as clean Scala libraries.

Is this a feature you would work on yourself?

  • I plan to open a pull request for this feature
@mdedetrich mdedetrich added the good first issue Good for newcomers label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant