Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pages do not have <title> #324

Closed
hparra opened this issue Apr 1, 2024 · 7 comments · Fixed by #335
Closed

Pages do not have <title> #324

hparra opened this issue Apr 1, 2024 · 7 comments · Fixed by #335
Labels
bug Something isn't working

Comments

@hparra
Copy link

hparra commented Apr 1, 2024

Pages do not have a <title>. Seems to affect all pages. Gatsby misconfiguration?

Expected Behaviour

HTML Document contains a <title> in <head>.

Actual Behaviour

Not there!

Sample Code that illustrates the problem

Chrome Developer Console: document.querySelector('title')

Screenshot 2024-04-01 at 12 27 27

PSI: https://pagespeed.web.dev/analysis/https-developer-adobe-com-app-builder-docs-guides-security/z137yjyy22?form_factor=mobile

Screenshot 2024-04-01 at 12 35 21
@hparra
Copy link
Author

hparra commented Apr 1, 2024

Interestingly Google SERP seems to be generating a title on our behalf:

Screenshot 2024-04-01 at 12 38 35

@shazron
Copy link
Member

shazron commented Apr 2, 2024

I believe this is set dynamically using Javascript. If you go to the Console, document.title should be there.

@shazron
Copy link
Member

shazron commented Apr 2, 2024

although the thing I see is, that it doesn't even update the page title properly - for me https://developer.adobe.com/app-builder/docs/guides/security/ or any other Guides page is always Guides

@shazron
Copy link
Member

shazron commented Apr 2, 2024

Update: if you go there using the direct url above for Security, it doesn't have a title, but navigating around the breadcrumbs it will eventually set it, but it is not correct

@shazron shazron added the bug Something isn't working label Apr 2, 2024
@aiojbot
Copy link

aiojbot commented Apr 2, 2024

JIRA issue created: https://jira.corp.adobe.com/browse/AIOE-669

@shazron
Copy link
Member

shazron commented May 15, 2024

I believe the fix is to simply add a title property in the front matter of the Markdown, e.g.

---
title: My Page Title | Parent Page Title 
---

shazron added a commit that referenced this issue May 15, 2024
@shazron
fix: pages do not have <title>
5f75803 
Auto-gen'ed titles from the first page heading, if applicable.
fixes #324
@shazron shazron mentioned this issue May 15, 2024
Merged
10 tasks
@shazron
Copy link
Member

shazron commented May 15, 2024

PR #335

purplecabbage pushed a commit that referenced this issue May 21, 2024
@shazron
fix: pages do not have <title> (#335)
4bd35d6 
Auto-gen'ed titles from the first page heading, if applicable.
fixes #324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pages do not have <title> AdobeDocs/app-builder
3 participants
@hparra @shazron @aiojbot