Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Getting Started optional tools section with latest Node14 Docker images #131

Open
meryllblanchet opened this issue Sep 27, 2021 · 3 comments

Comments

@meryllblanchet
Copy link
Collaborator

https://github.com/AdobeDocs/project-firefly/blob/main/src/pages/getting_started/index.md

  1. Node10 and Node12 images are mentioned, but Node14 images should be preferably used.
  2. The documentation could be clearer about when to download the images manually (e.g. on slow connections).
@shazron
Copy link
Member

shazron commented Sep 27, 2021

adobeapiplatform/adobe-action-nodejs-v10 is at 3.0.28 now
adobeapiplatform/adobe-action-nodejs-v12 is at 3.0.28 now
adobeapiplatform/adobe-action-nodejs-v14 is at 3.0.28 now

@shazron
Copy link
Member

shazron commented Sep 27, 2021

Related: adobe/aio-cli-plugin-app#481

@elagun
Copy link

elagun commented Sep 27, 2021

It should also be noted in the Optional Tools section that these Docker image need not be pulled manually. They will be downloaded and run automatically by the CLI when running aio app:run --local.

Especially the part "The following commands must be executed to install the required Docker images" should be removed because it's not correct. In fact the CLI will most probably download a different version and not use the Docker image that you downloaded manually at all. For example, I manually downloaded v14:3.0.28 and then running the local development the CLI ignored this image and downloaded and ran v14:3.0.26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants