We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello,
Thanks for providing this library, I appreciate the effort. Not sure if this is really an issue, but I thought I'd raise an ticket nonetheless.
When setting marginPagesDisplayed to 0, I excepted the pagination to render like this:
marginPagesDisplayed
<ReactPaginate pageRangeDisplayed={4} marginPagesDisplayed={0} onPageChange={handlePageClick} pageCount={pageCount} forcePage={page} />
Instead, there is a break at the end:
The issue seems to be coming from this line:
react-paginate/react_components/PaginationBoxView.js
Lines 470 to 471 in 98db5f7
I reckon these two checks need to be separated:
// We do not show break if only one active page is displayed. pageRangeDisplayed > 0 && marginPagesDisplayed > 0
Let me know if you'd like me to submit a PR!
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Hello,
Thanks for providing this library, I appreciate the effort. Not sure if this is really an issue, but I thought I'd raise an ticket nonetheless.
When setting
marginPagesDisplayed
to 0, I excepted the pagination to render like this:Instead, there is a break at the end:
The issue seems to be coming from this line:
react-paginate/react_components/PaginationBoxView.js
Lines 470 to 471 in 98db5f7
I reckon these two checks need to be separated:
Let me know if you'd like me to submit a PR!
The text was updated successfully, but these errors were encountered: