Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performant occlusion of columns (module not found when extending ember-tbody) #962

Open
johanrd opened this issue Aug 26, 2022 · 0 comments

Comments

@johanrd
Copy link
Contributor

johanrd commented Aug 26, 2022

I have a table with a lot more columns than rows (the columns can be a long scroll of dates, easily more than hundred):

Scoreboard April 2 April 3 April 4 April 5 April 6 April 7 April 8 April 9 April 10 April 11 April 12 April 13
Person A 9 8 6 6 5 10 78 13 8 83 7 9
Person B 8 2 9 0 8 72 72 9 9 0 0 5

Ember table struggles with the performance here, and I guess that is because it is not built for horizontal occlusion.

Over at vertical-collection there is a horizontal-collection PR which I was tempted to try out by extending ember-tbody. However, when trying to extend ember-tbody, I get the following error on import:

// ember-tbody-horizontal.js
import EmberTbody from 'ember-table/components/ember-tbody/component';
export default class EmberTbodyHorizontal extends EmberTbody {}
-Cannot find module 'ember-table/components/ember-tbody/component' or its corresponding type declarations.

I was planning to extend ember-tbody in the following way:

// ember-tbody-horizontal.hbs
-{{#vertical-collection
+{{#horzontal-collection
...

As I understand from @pzuraq's comment on #612, extending a component is an anti-pattern in the first place – are there any other composable way to try out horizontal collection for performant occlusion of columns?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant