Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember auto import related error getting thrown when installing ember table v4.0.0 #959

Open
ahemed-haneen opened this issue Aug 3, 2022 · 9 comments

Comments

@ahemed-haneen
Copy link

ahemed-haneen commented Aug 3, 2022

ember-cli - v3.28

  • message: ember-classy-page-object needs to depend on ember-auto-import in order to use ember-cli-page-object
ERROR Summary:

  - broccoliBuilderErrorStack: [undefined]
  - code: [undefined]
  - codeFrame: [undefined]
  - errorMessage: ember-classy-page-object needs to depend on ember-auto-import in order to use ember-cli-page-object
  - errorType: [undefined]
  - location:
    - column: [undefined]
    - file: [undefined]
    - line: [undefined]
  - message: ember-classy-page-object needs to depend on ember-auto-import in order to use ember-cli-page-object
  - name: Error
  - nodeAnnotation: [undefined]
  - nodeName: [undefined]
  - originalErrorMessage: [undefined]
  - stack: Error: **ember-classy-page-object needs to depend on ember-auto-import in order to use ember-cli-page-object**
    at Class.included (/home/developer/Projects/js/test-ember-table-app/node_modules/@embroider/addon-shim/src/index.js:51:27)
    at Class.superWrapper [as included] (/home/developer/Projects/js/test-ember-table-app/node_modules/core-object/lib/assign-properties.js:34:20)
    at /home/developer/Projects/js/test-ember-table-app/node_modules/ember-cli/lib/models/addon.js:497:26
    at Array.reduce (<anonymous>)
    at Class.eachAddonInvoke (/home/developer/Projects/js/test-ember-table-app/node_modules/ember-cli/lib/models/addon.js:494:24)
    at Class.included (/home/developer/Projects/js/test-ember-table-app/node_modules/ember-cli/lib/models/addon.js:769:10)
    at Class.superWrapper [as included] (/home/developer/Projects/js/test-ember-table-app/node_modules/core-object/lib/assign-properties.js:34:20)
    at /home/developer/Projects/js/test-ember-table-app/node_modules/ember-cli/lib/models/addon.js:497:26
    at Array.reduce (<anonymous>)
    at Class.eachAddonInvoke (/home/developer/Projects/js/test-ember-table-app/node_modules/ember-cli/lib/models/addon.js:494:24)

@mixonic any idea?

@yaxinr
Copy link

yaxinr commented Aug 4, 2022

temporarily for pnpm add to packege.json

  "pnpm": {
    "overrides": {
      "ember-cli-page-object": "< 1.17.9"
    }
  },

@ahemed-haneen
Copy link
Author

@yaxinr thankyou. i too had a hunch that downgrading to ember-classy-page-object@^0.7.0 would resolve this issue. but am using yarn(v1 - classic) as package manager so have no clue how to override in yarn

@yaxinr
Copy link

yaxinr commented Aug 4, 2022 via email

@ascudder
Copy link
Contributor

I opened a PR to try to fix this in the ember-classy-page-object repository, let me know if this helps: Addepar/ember-classy-page-object#38

@ginomiglio
Copy link

This is specifically an incompatibility with ember-cli-page-object >= v2.0.0-beta.4. You can add a yarn resolution for v2.0.0-beta.3 to work around the problem in the cleanest way possible. See Addepar/ember-classy-page-object#39 for details.

@liberlanco
Copy link

liberlanco commented Aug 19, 2022

This is specifically an incompatibility with ember-cli-page-object >= v2.0.0-beta.4.

Thank you, that helped. I tried to fix version of ember-classy-page-object in dependencies without success, but then just added into package.json > dependencies list:

       "ember-cli-page-object": "v2.0.0-beta.3"

and now it works.

node@98e52f465a88:/app/client$ ember -v
ember-cli: 4.1.1
node: 14.20.0

@ginomiglio
Copy link

FYI Addepar/ember-classy-page-object#39 was fixed and released, so if you use ember-classy-page-object v0.8.0-beta.2 this problem should no longer happen. We can probably close this issue now.

@rreckonerr
Copy link

@ginomiglio Is this issue possibly related to ember-cli-page-object/ember-classy-page-object?

@ginomiglio
Copy link

I'm not sure. I don't think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants