Find a more generic place for color overrides

[github-actions]

Find a more generic place for color overrides

Private

=======

hydridic_blender/utils/material_factory.py

Line 105 in fbfde06

# TODO: Find a more generic place for color overrides

        Returns:
            bpy.types.Material: A material for the given chemical symbol.
        """
        key = self._get_material_key(chemical_id, symbol)
        material = bpy.data.materials.get(key)
        if material is None:
            material = self._create_material(symbol, key)
        return material

    def _get_material_key(self, chemical_id: str, symbol: str) -> str:
        """Creates a unique human-readable key for a material

        Args:
            symbol (str): Chemical symbol for the material.
            chemical_id (str): A unique identifier for a material.

        Returns:
            str: A unique human-readable key for the material
        """
        if self.materials_are_singleton:
            key = f"{PACKAGE_PREFIX}_{symbol}"
        else:
            key = f"{PACKAGE_PREFIX}_{symbol}_{chemical_id}"
        return key

    def _create_material(self, symbol: str, key: str) -> bpy.types.Material:
        """Creates a material given a symbol and chemical id. Uses JMol colors.

        Args:
            symbol (str): Chemical symbol for the material.
            chemical_id (str): A unique identifier for a material.

        Returns:
            bpy.types.Material: A material for the given chemical symbol.
        """

        color = [i for i in ase.data.colors.jmol_colors[ase.data.atomic_numbers[symbol]]] + [1]
        # TODO: Find a more generic place for color overrides
        if symbol == "C":
            color = [0.0, 0.0, 0.0, 1.0]

        material: bpy.types.Material = bpy.data.materials.new(key)

        # Find the principled node
        material.use_nodes = True
        shader: bpy.types.ShaderNodeBsdfPrincipled = material.node_tree.nodes.get('Principled BSDF')

        # Set some general material properties
        shader.inputs[BSDF_SHADER_INPUTS["Base Color"]].default_value = color
        if ase.data.atomic_numbers[symbol] in METALS:
            shader.inputs[BSDF_SHADER_INPUTS["Metallic"]].default_value = 1.0
            shader.inputs[BSDF_SHADER_INPUTS["Roughness"]].default_value = 0.2
            shader.inputs[BSDF_SHADER_INPUTS["Clearcoat"]].default_value = 0.0
        else:
            shader.inputs[BSDF_SHADER_INPUTS["Metallic"]].default_value = 0.0
            shader.inputs[BSDF_SHADER_INPUTS["Roughness"]].default_value = 1.0
            shader.inputs[BSDF_SHADER_INPUTS["Clearcoat"]].default_value = 1.0

        return material

4972fd968cfee7af756769a7e162301ee8299a40