Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly typed DomainDetails:SafeToRemoveRevokedKeyFromDNS - is string, should be boolean #157

Open
cameroncf opened this issue Apr 23, 2024 · 0 comments · May be fixed by #158
Open

Incorrectly typed DomainDetails:SafeToRemoveRevokedKeyFromDNS - is string, should be boolean #157

cameroncf opened this issue Apr 23, 2024 · 0 comments · May be fixed by #158

Comments

@cameroncf
Copy link

cameroncf commented Apr 23, 2024 •
edited

The SafeToRemoveRevokedKeyFromDNS property of DomainDetails is (incorrectly) typed as a string in Postmark's NPM package (source), but it's a boolean in the examples and in actual data returned from the API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct type for SafeToRemoveRevokedKeyFromDNS (from string to boolean) cameroncf/postmark.js
1 participant
@cameroncf