Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate Townlong Yak? #348

Open
csutcliff opened this issue Sep 24, 2022 · 11 comments
Open

Reinstate Townlong Yak? #348

csutcliff opened this issue Sep 24, 2022 · 11 comments

Comments

@csutcliff
Copy link

Hi,

Now that the Townlong Yak addons are being updated again is there anything blocking them being reinstated as a source in CurseBreaker?

https://www.townlong-yak.com/addons/

@AcidWeb
Copy link
Owner

AcidWeb commented Sep 24, 2022

Site is back but API is not. I would love to re-add TY support.

@Barleduq
Copy link
Sponsor

Would it make more sense for you, @AcidWeb , to contact the author at Townlong Yak and ask about being able to download from there again, or one of us users? To be honest, a user talking to them and then telling you feels like it will introduce errors ala the game of Telephone. But if you'd rather someone else make the initial contact, I'll be happy to.

@AcidWeb
Copy link
Owner

AcidWeb commented Oct 24, 2022

He knows.

@jfdhuiz
Copy link

jfdhuiz commented Jul 15, 2023

If known, why not resort to scraping and parsing the HTML with say BeautifulSoup. It is their choice they don't want to implement a free API. Same for Tukui/ElvUI and Wago. We both lose, sadly, but as stated: by their choice. Not ours.

@AcidWeb
Copy link
Owner

AcidWeb commented Jul 15, 2023

Because this application have strict no scraping policy.

(Also ElvUI/Tukui have API.)

@jfdhuiz
Copy link

jfdhuiz commented Jul 15, 2023

Why do you have such policy? What does it matter whether I use an automated program or a manual program to see if I have the latest version of addons? As long as I don't F5 every second it should be OK.

@AcidWeb
Copy link
Owner

AcidWeb commented Jul 16, 2023

It matters for me.

@jfdhuiz
Copy link

jfdhuiz commented Jul 16, 2023

And you're not willing to share why.

@AcidWeb
Copy link
Owner

AcidWeb commented Jul 16, 2023

If site don't provide usable API that mean third party updaters are not welcomed there. I'm quite deep in WoW addon author community and I have different look on the stance you presenting.

@JasonBristol
Copy link

If known, why not resort to scraping and parsing the HTML with say BeautifulSoup. It is their choice they don't want to implement a free API. Same for Tukui/ElvUI and Wago. We both lose, sadly, but as stated: by their choice. Not ours.

Scraping isn't an interface and therefore unmaintainable at worst, and fragile to changes to their UIs at best, something you can avoid entirely with a versioned API

Not sure why their API is disabled, but it's not worth the headache and likely performance hit to CB even if the author wanted to implement it

@AcidWeb
Copy link
Owner

AcidWeb commented Apr 11, 2024

Status update: Some of his addons are available on CF. Libraries got GIT repository support for packager. Sadly there is still no API to access the addons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants