{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":643020161,"defaultBranch":"main","name":"OpenPBR","ownerLogin":"AcademySoftwareFoundation","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2023-05-19T22:20:39.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/40807682?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717471337.0","currentOid":""},"activityList":{"items":[{"before":"95b4f20e3c5bd450012e8cd0bc7c59bddbdfdbff","after":"44fe76650880914980402221672446ad44df15bd","ref":"refs/heads/main","pushedAt":"2024-06-05T00:30:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Update specification and reference to v1.0 (#214)","shortMessageHtmlLink":"Update specification and reference to v1.0 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2332429083\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/214\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/214/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/214\">#214</a>)"}},{"before":"44fe76650880914980402221672446ad44df15bd","after":"95b4f20e3c5bd450012e8cd0bc7c59bddbdfdbff","ref":"refs/heads/main","pushedAt":"2024-06-05T00:19:49.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Move .html files from top level of repo to /html (#212)","shortMessageHtmlLink":"Move .html files from top level of repo to /html (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2326288448\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/212\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/212/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/212\">#212</a>)"}},{"before":"c7da82f59ccb7244b6bb01820fc0c5b617b6a389","after":"44fe76650880914980402221672446ad44df15bd","ref":"refs/heads/main","pushedAt":"2024-06-04T03:13:00.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Update specification and reference to v1.0 (#214)","shortMessageHtmlLink":"Update specification and reference to v1.0 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2332429083\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/214\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/214/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/214\">#214</a>)"}},{"before":"e9f122b591492e692f142fd83761cff619579a39","after":"c7da82f59ccb7244b6bb01820fc0c5b617b6a389","ref":"refs/heads/main","pushedAt":"2024-05-31T23:51:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Update BibTeX citation (date, and capitalization) (#213)\n\nUpdating the date to June.\r\n\r\nAlso forcing capitalization, so e.g. in journals (such as JCGT) which (annoyingly) render the titles by default as all lowercase, the capitalization of OpenPBR is retained, e.g. in JCGT.","shortMessageHtmlLink":"Update BibTeX citation (date, and capitalization) (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2328332462\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/213\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/213/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/213\">#213</a>)"}},{"before":"e33aaa0a453d08fa29f18ee6fbf5dd7a31a0c7b6","after":"e9f122b591492e692f142fd83761cff619579a39","ref":"refs/heads/main","pushedAt":"2024-05-31T23:50:05.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Diffuse base_weight description changed to match MaterialX EON implementation (#205)\n\nAs discussed in https://github.com/AcademySoftwareFoundation/MaterialX/pull/1822#issuecomment-2127738467, the MaterialX implementation assumed that the `base_weight` acts as an overall multiplier of the EON BRDF. While in the OpenPBR spec, we had `base_weight` instead multiplying `base_color`.\r\n\r\nIn fact the MaterialX intepretation seems better, since then the `base_weight` functions as a linear modulation of the overall albedo, rather than doing something non-linear and dependent on the color. This PR makes the necessary changes to the wording/math of the spec to implement this.","shortMessageHtmlLink":"Diffuse base_weight description changed to match MaterialX EON implem…"}},{"before":"4878b0a2094e9e1ddbdacf4de15f9a93fcdedcd6","after":"e33aaa0a453d08fa29f18ee6fbf5dd7a31a0c7b6","ref":"refs/heads/main","pushedAt":"2024-05-31T23:48:36.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Implement TIR fix in MaterialX (#203)","shortMessageHtmlLink":"Implement TIR fix in MaterialX (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2321168316\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/203\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/203/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/203\">#203</a>)"}},{"before":"8a17b0dbcaa98f20c5530033366b105633a629b9","after":"4878b0a2094e9e1ddbdacf4de15f9a93fcdedcd6","ref":"refs/heads/main","pushedAt":"2024-05-28T18:11:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Fix default value of transmission_dispersion_abbe_number in .mtlx (#206)","shortMessageHtmlLink":"Fix default value of transmission_dispersion_abbe_number in .mtlx (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2321439527\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/206\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/206/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/206\">#206</a>)"}},{"before":"a5daf051c4f6aaa62fdbab5ca7afd98388c2ab67","after":"8a17b0dbcaa98f20c5530033366b105633a629b9","ref":"refs/heads/main","pushedAt":"2024-05-28T18:04:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Add uiname field to .mtlx nodedef (#204)\n\nSince the Maya team noted that they need this field in order to derive the node name (with correct capitalization and word break) to show in the editor:\r\n>since the name of the node is open_pbr_surface, it will require custom code to turn it into \"OpenPBR Surface\".\r\n\r\n>uiname metadata is already in the MaterialX specifications in the \"[Custom Node Declaration NodeDef Elements](https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/documents/Specification/MaterialX.Specification.md#custom-node-declaration-nodedef-elements)\" section for MaterialX 1.39 and I see this as well in the old 1.38 specification. Feel free to add it to OpenPBR surface and I will make sure LookdevX uses it.","shortMessageHtmlLink":"Add uiname field to .mtlx nodedef (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2321184346\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/204\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/204/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/204\">#204</a>)"}},{"before":"ae070bed5195e655395a326511e0f107ea1e9864","after":"a5daf051c4f6aaa62fdbab5ca7afd98388c2ab67","ref":"refs/heads/main","pushedAt":"2024-05-23T22:51:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Enable diffuse energy compensation (#201)\n\nThis changelist adds the `energy_compensation` setting to `oren_nayar_diffuse_bsdf` in the reference implementation for OpenPBR, leveraging the upcoming support for this feature in MaterialX 1.39.\r\n\r\nIn recent MaterialX TSC meetings, we've aligned on this naming convention for the new energy compensation feature in oren_nayar_diffuse_bsdf, and it now seems safe to move forward with this setting in OpenPBR v1.0.","shortMessageHtmlLink":"Enable diffuse energy compensation (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2311611427\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/201\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/201/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/201\">#201</a>)"}},{"before":"57c3b8a071e20dcd1517b69f649b4dc4dd14f735","after":"ae070bed5195e655395a326511e0f107ea1e9864","ref":"refs/heads/main","pushedAt":"2024-05-16T22:56:25.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Add coat_darkening to default example (#199)\n\nThis changelist adds the coat_darkening input to our default material example, improving the visibility of this control in user testing.","shortMessageHtmlLink":"Add coat_darkening to default example (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2301441009\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/199\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/199/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/199\">#199</a>)"}},{"before":"dfa1e8a4276349c7ad533575ea9159cc3e31a02a","after":"57c3b8a071e20dcd1517b69f649b4dc4dd14f735","ref":"refs/heads/main","pushedAt":"2024-05-16T18:34:07.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Update acknowledgement list (#198)","shortMessageHtmlLink":"Update acknowledgement list (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2300298297\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/198\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/198/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/198\">#198</a>)"}},{"before":"37f7489bdbcd5645ed6dac552a681e18ad91b40c","after":"dfa1e8a4276349c7ad533575ea9159cc3e31a02a","ref":"refs/heads/main","pushedAt":"2024-05-14T22:46:40.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Update specification and reference to v0.5 (#196)","shortMessageHtmlLink":"Update specification and reference to v0.5 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2296536334\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/196\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/196/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/196\">#196</a>)"}},{"before":"f34453c6c5bf11ecfb3ae137fdec0742cee4a660","after":"37f7489bdbcd5645ed6dac552a681e18ad91b40c","ref":"refs/heads/main","pushedAt":"2024-05-14T22:39:28.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Update contributors list (#195)","shortMessageHtmlLink":"Update contributors list (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2296489181\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/195\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/195/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/195\">#195</a>)"}},{"before":"7d7c2e4dd2e5ed4d7e9d27410c64bfc1debedb81","after":"f34453c6c5bf11ecfb3ae137fdec0742cee4a660","ref":"refs/heads/main","pushedAt":"2024-05-14T22:38:30.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Slightly shift TOC closer to teaser image (#194)","shortMessageHtmlLink":"Slightly shift TOC closer to teaser image (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2296480282\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/194\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/194/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/194\">#194</a>)"}},{"before":"aa95c1b802d83a3737a83e9c837aba6563001720","after":"7d7c2e4dd2e5ed4d7e9d27410c64bfc1debedb81","ref":"refs/heads/main","pushedAt":"2024-05-14T21:55:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Initial specification cleanup for 1.0 (#191)","shortMessageHtmlLink":"Initial specification cleanup for 1.0 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2294172299\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/191\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/191/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/191\">#191</a>)"}},{"before":"b7f3e982614b3aa94e412169632bf760b6ebccb3","after":"aa95c1b802d83a3737a83e9c837aba6563001720","ref":"refs/heads/main","pushedAt":"2024-05-14T20:40:32.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Add white furnace testing section (#192)\n\nAddresses #146.","shortMessageHtmlLink":"Add white furnace testing section (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2295555094\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/192\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/192/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/192\">#192</a>)"}},{"before":"0a760074b39752bbc25f494c6d2501d1e5bbdb20","after":"b7f3e982614b3aa94e412169632bf760b6ebccb3","ref":"refs/heads/main","pushedAt":"2024-05-14T20:38:56.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Update the coat_darkening parameter to default to 1 (#193)","shortMessageHtmlLink":"Update the coat_darkening parameter to default to 1 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2296217569\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/193\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/193/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/193\">#193</a>)"}},{"before":"de8fc5a6edb0e04db0aa91d13725b29f1ad5367c","after":"0a760074b39752bbc25f494c6d2501d1e5bbdb20","ref":"refs/heads/main","pushedAt":"2024-05-14T20:37:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Add a discussion/solution of the coat \"spurious TIR\" issue (#166)\n\nThis addresses the points raised in #142.\r\n\r\nI made it a sub-section of the Coat section, as it relates to accounting for the presence of the coat in the implementation of the dielectric/specular BSDF, but it could possibly go in the earlier Dielectric base section with a forward reference.","shortMessageHtmlLink":"Add a discussion/solution of the coat \"spurious TIR\" issue (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2155065103\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/166\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/166/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/166\">#166</a>)"}},{"before":"e7ec2c7875c115027e9a24901dd21af9960b056f","after":"de8fc5a6edb0e04db0aa91d13725b29f1ad5367c","ref":"refs/heads/main","pushedAt":"2024-05-14T02:46:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Layer diagram improvements (#189)\n\nImproved this diagram a bit:\r\n\r\n- expanded the glossy-diffuse slab to represent it as layer of clear-coat dielectric gloss on diffuse, as it is defined in the text. \r\n- indicated the transparent slabs that have embedded volume (i.e. all except the gloss).\r\n- the number of slabs (i.e. the boxes) is now 8, matching the formal structure of the model (see bottom)\r\n- also there are 5 transparent slabs, corresponding to the 5 slabs with a VDF in the formal structure.","shortMessageHtmlLink":"Layer diagram improvements (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2291011396\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/189\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/189/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/189\">#189</a>)"}},{"before":"8d83f867f15b78970404c456a9a9f36b5c981e06","after":"e7ec2c7875c115027e9a24901dd21af9960b056f","ref":"refs/heads/main","pushedAt":"2024-05-14T01:03:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Coat roughening convolution formula (#172)\n\nEssentially, an improved version of the Standard Surface roughening formula. We need to suggest some approximation, as implementations need to account for this somehow. As discussed on Slack, thinking about the roughening as a convolution suggests an \"as simple as possible\" physically-based formula for the effect. I assume this is closer to the ground truth than the ad-hoc Standard-Surface formula, but verifying that would require more work.","shortMessageHtmlLink":"Coat roughening convolution formula (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2244722170\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/172\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/172/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/172\">#172</a>)"}},{"before":"b275729eb8691d2c7b628093d39f507181fd3b29","after":"8d83f867f15b78970404c456a9a9f36b5c981e06","ref":"refs/heads/main","pushedAt":"2024-05-13T21:24:54.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Upgrade reference implementation to 1.39 (#188)\n\nThis changelist upgrades the reference implementation of OpenPBR to MaterialX 1.39, enabling the following improvements:\r\n\r\n- Enable Hoffman/Schlick Fresnel for metals, connecting the new color82 input of generalized_schlick_bsdf.\r\n- Update thin-film logic to include unit conversion and more accurate layering.\r\n- Update swizzle nodes and channel attributes for 1.39 syntax.\r\n- Remove a handful of default-valued inputs for clarity.","shortMessageHtmlLink":"Upgrade reference implementation to 1.39 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2291000344\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/188\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/188/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/188\">#188</a>)"}},{"before":"67f0ea5c57b23df3af512e56cd48edaa019516de","after":"b275729eb8691d2c7b628093d39f507181fd3b29","ref":"refs/heads/main","pushedAt":"2024-05-13T13:23:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"AdrienHerubel","name":"Adrien Herubel","path":"/AdrienHerubel","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/947159?s=80&v=4"},"commit":{"message":"Specify the anisotropy direction (#170)\n\n* Specify the anisotropy flow map\r\n\r\n* Name anisotropy parameters more consistently\r\n\r\n* Specify anisotropy direction as a property of the NDF\r\n\r\n* Replace `coat_normal` with `geometry_coat_normal`\r\n\r\n* Define the NDF stretching direction to be along T\r\n\r\n* The anisotropy direction depends only on the provided tangent vector fields\r\n\r\n* Typo\r\n\r\n* Typo\r\n\r\n* Update MaterialX implementation\r\n\r\n* Rename remaining occurrences of subsurface_anisotropy to subsurface_scatter_anisotropy\r\n\r\n* Update examples\r\n\r\n* Update index.html\r\n\r\nCo-authored-by: Jamie Portsmouth <jamports@mac.com>\r\nSigned-off-by: Julien Guertault <9511025+virtualzavie@users.noreply.github.com>\r\n\r\n* Update index.html\r\n\r\nCo-authored-by: Jamie Portsmouth <jamports@mac.com>\r\nSigned-off-by: Julien Guertault <9511025+virtualzavie@users.noreply.github.com>\r\n\r\n---------\r\n\r\nSigned-off-by: Julien Guertault <9511025+virtualzavie@users.noreply.github.com>\r\nCo-authored-by: Adrien Herubel <AdrienHerubel@users.noreply.github.com>\r\nCo-authored-by: Jamie Portsmouth <jamports@mac.com>","shortMessageHtmlLink":"Specify the anisotropy direction (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2195555206\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/170\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/170/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/170\">#170</a>)"}},{"before":"a502bb4b1495c61df5a00db3739cdc2716784187","after":"67f0ea5c57b23df3af512e56cd48edaa019516de","ref":"refs/heads/main","pushedAt":"2024-05-11T19:42:33.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Define Oren-Nayar lobe explicitly as EON model (i.e. energy-compensated Fujii) (#174)\n\nAs discussed extensively on Slack, our specification of the diffuse lobe is incomplete since we don't make it clear what form of the Oren-Nayar model to take, and there are several options.\r\n\r\nAs argued on Slack, I think the model proposed by Fujii makes the most sense, as it: \r\n   - fixes the dark ring artifacts in the original \"qualitative Oren-Nayar\"\r\n   - is less dark than the original \"qualitative Oren-Nayar\" (energy preserving at grazing)\r\n   - $\\sigma$ parameter has more obvious meaning as the $[0,1]$ \"weight of non-Lambertian-ness\".\r\n   - looks better in renders (subjectively)\r\n\r\nIt is also easy to add straightforward energy compensation so that:\r\n   - the model is fully energy preserving, so passes a white furnace test\r\n   - exhibits saturation of the albedo, as physically expected for a multiple scattering microfacet model\r\n\r\nThis model is also very easy to implement (no tabulation) and efficient (even more-so than qualitative Oren-Nayar), via an accurate fit thanks to the analytical solution for the albedo.","shortMessageHtmlLink":"Define Oren-Nayar lobe explicitly as EON model (i.e. energy-compensat…"}},{"before":"c57cc0c913b04ac0478333e61daf29f55bc851f7","after":"a502bb4b1495c61df5a00db3739cdc2716784187","ref":"refs/heads/main","pushedAt":"2024-05-10T22:28:45.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Fix IOR schematic figure in thin-film section (#185)\n\nFixes image link (name was wrong).","shortMessageHtmlLink":"Fix IOR schematic figure in thin-film section (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2286289386\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/185\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/185/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/185\">#185</a>)"}},{"before":"b23184348c28fc344ee5f0bd6c5c4e6e89384216","after":"c57cc0c913b04ac0478333e61daf29f55bc851f7","ref":"refs/heads/main","pushedAt":"2024-05-10T19:47:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Remove conclusion section (#186)\n\nSince it's a specification, not a paper making an argument based on methods and results.. Also this \"conclusion\" is fairly content-free, so not helpful.","shortMessageHtmlLink":"Remove conclusion section (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2290171130\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/186\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/186/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/186\">#186</a>)"}},{"before":"ffcc368ef8e90dec259d0e9c3ef925b93663318f","after":"b23184348c28fc344ee5f0bd6c5c4e6e89384216","ref":"refs/heads/main","pushedAt":"2024-05-10T19:46:34.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Add coat darkening and saturation effects (#162)\n\nThis PR adds a detailed discussion to the spec of the coat darkening effect (incorporating the ideas discussed in https://github.com/AcademySoftwareFoundation/OpenPBR/issues/136 and https://github.com/AcademySoftwareFoundation/OpenPBR/issues/141), with:\r\n  - introduction of a new `coat_darkening` parameter (defaulting to 1, the physically correct case).\r\n  - a physical definition of how this parameter operates to reduce the darkening (via boosting of the base albedo)\r\n  - a suggested practical implementation of the darkening factor for the base lobe, taking into account the IOR of the coat, and also the roughness of the base (based on the derivations and discussions linked elsewhere).\r\n  - A suggested implementation of the darkening of colored coats at grazing angles due to longer path length in the absorbing medium.","shortMessageHtmlLink":"Add coat darkening and saturation effects (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2139502150\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/162\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/162/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/162\">#162</a>)"}},{"before":"86c060d3739692dc5b3c5100d4678fe39d11bf60","after":"ffcc368ef8e90dec259d0e9c3ef925b93663318f","ref":"refs/heads/main","pushedAt":"2024-05-09T00:04:50.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Fix uifolder name for subsurface weight (#184)\n\nSubsurface weight has uifolder and uiname values switched.","shortMessageHtmlLink":"Fix uifolder name for subsurface weight (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2286083278\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/184\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/184/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/184\">#184</a>)"}},{"before":"10bd820b2ffd25526e92d5fdcc05bd39537222dc","after":"86c060d3739692dc5b3c5100d4678fe39d11bf60","ref":"refs/heads/main","pushedAt":"2024-05-08T16:54:33.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Rework readme links (#182)\n\nAs suggested during the discussions, this PR renames the link to the specification, and removes the link to the GitHub issues.","shortMessageHtmlLink":"Rework readme links (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2285067739\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/182\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/182/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/182\">#182</a>)"}},{"before":"71d27bf9b3b299f6e66867b4cd00bcf3b0a2766d","after":"10bd820b2ffd25526e92d5fdcc05bd39537222dc","ref":"refs/heads/main","pushedAt":"2024-05-08T16:53:31.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Remove Future work notes and left over comments (#181)\n\nIt was my understanding during the discussions that we prefered to rely on PRs and issues regarding future work, rather than notes in the specification. This PR therefore removes the \"Future work\" notes from the document, as well as a left over comment (former parameters of the coat).","shortMessageHtmlLink":"Remove Future work notes and left over comments (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2285028565\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/181\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/181/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/181\">#181</a>)"}},{"before":"74ecb22792d990807c749a3a371e50d48b76b5ae","after":"71d27bf9b3b299f6e66867b4cd00bcf3b0a2766d","ref":"refs/heads/main","pushedAt":"2024-05-07T18:40:05.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jstone-lucasfilm","name":"Jonathan Stone","path":"/jstone-lucasfilm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6146549?s=80&v=4"},"commit":{"message":"Thin-film improvements (#167)\n\nThis addresses the following:\r\n\r\n- Implementing thin-film interference in combination with F82-tint metallic Fresnel #79\r\n- For consistency, every section should have a \"weight\" parameter. #134\r\n- Thin film in micrometers divided by 2 for normalized parameter range #150","shortMessageHtmlLink":"Thin-film improvements (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2159827531\" data-permission-text=\"Title is private\" data-url=\"https://github.com/AcademySoftwareFoundation/OpenPBR/issues/167\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/AcademySoftwareFoundation/OpenPBR/pull/167/hovercard\" href=\"https://github.com/AcademySoftwareFoundation/OpenPBR/pull/167\">#167</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEXJJOUQA","startCursor":null,"endCursor":null}},"title":"Activity · AcademySoftwareFoundation/OpenPBR"}