Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more tolerance in pair inverse detection #1970

Open
doug-walker opened this issue Apr 27, 2024 · 0 comments
Open

Allow more tolerance in pair inverse detection #1970

doug-walker opened this issue Apr 27, 2024 · 0 comments
Labels
Bug Unwanted or incorrect behavior in currently available functionality.

Comments

@doug-walker
Copy link
Collaborator

The optimizer will remove pairs of adjacent ops that are inverses of each other. However, the comparison is probably more strict than it needs to be. For example these ops are not removed:

        <FixedFunction direction=inverse, style=REC2100_Surround, params=0.833333333333333>
        <FixedFunction direction=forward, style=REC2100_Surround, params=0.8333333333333334>

This is especially problematic since the CTF writer will output the param from line 2 as the value from line 1.

The tolerance for making these comparisons should be increased slightly.

@doug-walker doug-walker added the Bug Unwanted or incorrect behavior in currently available functionality. label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unwanted or incorrect behavior in currently available functionality.
Projects
None yet
Development

No branches or pull requests

1 participant