Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ociobakelut difference between 2.3.2 and 2.3.1 #1953

Open
lutifyme opened this issue Feb 23, 2024 · 4 comments
Open

ociobakelut difference between 2.3.2 and 2.3.1 #1953

lutifyme opened this issue Feb 23, 2024 · 4 comments
Labels
Bug Unwanted or incorrect behavior in currently available functionality. Help Wanted Issues that the TSC has decided are worth implementing, but don't currently have the dev resources.

Comments

@lutifyme
Copy link

lutifyme commented Feb 23, 2024

Hi all,

I'm using ociobakelut to convert a config-free .cube 33x33x33 LUT to .icc.

When I do this in 2.3.1 I get a good conversion.
When I do this in 2.3.2 the blacks are elevated.

The command I'm using is:
ociobakelut --lut {inputFile} --format icc {outputFile}

Here is how the curves of a resulting .icc profile created with version 2.3.1 look like:
https://www.dropbox.com/scl/fi/nnow10m5odvhnlfshmke8/Screenshot-2024-02-23-at-11.06.55.png?rlkey=wqcs4bsbj3vwvjr2ts3lsl2ds&dl=0
This is correct. They are identical to the .cube LUT.

Here is how the curves of the resulting .icc profile created with version 2.3.2 look like:
https://www.dropbox.com/scl/fi/jmfixgkdaqrdsn82lo1ef/Screenshot-2024-02-23-at-11.07.15.png?rlkey=c5wkwhmshdo5icmkprfphrpfm&dl=0
Notice the elevated blacks. This is incorrect.

Has something changed between 2.3.1 and 2.3.2 that I'm not aware of? I can't find anything in the changelog that would indicate this.

I should note that version 2.3.2 was installed via the Python method as per documentation, while 2.3.1 was installed from source.

Is this a bug?

Thanks!

@lutifyme
Copy link
Author

So it's not an issue of a version but rather installing via Python opposed to building from source.

When installing via Python both 2.3.2 and 2.3.1 exhibit this issue.

When building from source both 2.3.2 and 2.3.1 work well.

Any idea why this is?

I'm using ocio in Docker machine and building from source is too slow for any meaningful deployment time.

@remia
Copy link
Collaborator

remia commented Feb 24, 2024

Thanks for the report @lutifyme, are you able to share the LUT (or say if the issue happen on any LUT) and the environment to reproduce in (what is the Docker image Linux for example)? I tried to generate ICC profiles from macOS and see no difference between a build from source and the Python wheels for the time being.

I'm using ocio in Docker machine and building from source is too slow for any meaningful deployment time.

You only have to build once during the image creation right?

@lutifyme
Copy link
Author

Hi @remia thanks for getting back to me.

Sure thing, here is the LUT I'm converting.
https://www.dropbox.com/scl/fi/qhknre41vcbt7iklsm4gy/comboraw-step1lut-server.cube?rlkey=4m44ase50d3eamwjllwamxzd2&dl=0

I can't say if it's happening for more LUTs as I haven't tested much more, I stopped when I noticed the issue I'm experiencing.

What details about the environment would you need exactly? I've experienced this issue on Ubuntu 22.04 LTS machine as well (not Docker) so do let me know which details would be important to know. The Docker is Debian 12 Bookworm. I believe I could install using package manager on Debian but I think the latest one available is 2.1.2 unfortunately in that case.

You only have to build once during the image creation right?
Yes, but if more Docker instances are needed to be spun-up it could be an issue due to the time it takes to compile.

Thanks!

@remia
Copy link
Collaborator

remia commented Feb 25, 2024

Thanks @lutifyme, I think the difference might be due to the lcms2 version used when you compile from source? I tried compiling with lcms2 2.16 and indeed see the raised black go away. Will need to dig deeper to understand what is going on exactly.

@carolalynn carolalynn added Help Wanted Issues that the TSC has decided are worth implementing, but don't currently have the dev resources. Bug Unwanted or incorrect behavior in currently available functionality. labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unwanted or incorrect behavior in currently available functionality. Help Wanted Issues that the TSC has decided are worth implementing, but don't currently have the dev resources.
Projects
None yet
Development

No branches or pull requests

3 participants