Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build with Java 22 #886

Open
2 tasks done
RyanTheAllmighty opened this issue Apr 6, 2024 · 3 comments
Open
2 tasks done

Cannot build with Java 22 #886

RyanTheAllmighty opened this issue Apr 6, 2024 · 3 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs. high-priority High priority to be addressed.

Comments

@RyanTheAllmighty
Copy link
Member

What happened?

Cannot build the project with Java 22 due to Gradle being outdated. Sounds like we're waiting on a Groovy update as well:

Gradle now supports using Java 22 for compiling, testing, and starting other Java programs. Selecting a language version is done using toolchains.
You cannot run Gradle 8.7 itself with Java 22 because Groovy still needs to support JDK 22. However, future versions are expected to provide this support.

There may be some work to upgrade as per https://docs.gradle.org/8.7/userguide/upgrading_version_8.html#changes_8.3

Operating System

Windows

Relevant log output

No response

Additional Information

No response

Is this actually a launcher bug?

  • I am sure this is a bug with the launcher and not an issue with running Minecraft

Code of Conduct

  • I agree to follow this project's Code of Conduct
@RyanTheAllmighty RyanTheAllmighty added bug Confirmed bugs or reports that are very likely to be bugs. high-priority High priority to be addressed. labels Apr 6, 2024
@RyanTheAllmighty
Copy link
Member Author

RyanTheAllmighty commented May 21, 2024

I don't think this can be closed yet. From https://docs.gradle.org/8.7/release-notes.html#support-for-building-projects-with-java-22:~:text=and%20usability%20improvements-,Support%20for%20building%20projects%20with%20Java%2022,-Gradle%20now%20supports

You cannot run Gradle 8.7 itself with Java 22 because Groovy still needs to support JDK 22. However, future versions are expected to provide this support.

This is the main issue we have currently with running AUR builds has been this and is currently being worked around in a hacky way.

Or is the fact we moved to Kotlin solve this since it only mentions Groovy. Can it just be tested with Java 22 first?

@Doomsdayrs Doomsdayrs reopened this May 21, 2024
@Doomsdayrs
Copy link
Collaborator

I don't think this can be closed yet. From https://docs.gradle.org/8.7/release-notes.html#support-for-building-projects-with-java-22:~:text=and%20usability%20improvements-,Support%20for%20building%20projects%20with%20Java%2022,-Gradle%20now%20supports

You cannot run Gradle 8.7 itself with Java 22 because Groovy still needs to support JDK 22. However, future versions are expected to provide this support.

This is the main issue we have currently with running AUR builds has been this and is currently being worked around in a hacky way.

Or is the fact we moved to Kotlin solve this since it only mentions Groovy. Can it just be tested with Java 22 first?

I tested it with Java 22 on my system, thus closing it as I found no issues.

Did you do a build test yet?

@RyanTheAllmighty
Copy link
Member Author

Nah just wanted to make sure it was all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs. high-priority High priority to be addressed.
Development

No branches or pull requests

2 participants