Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher multi tasking #551

Open
RyanTheAllmighty opened this issue Feb 9, 2022 · 9 comments
Open

Launcher multi tasking #551

RyanTheAllmighty opened this issue Feb 9, 2022 · 9 comments
Labels
enhancement Feature requests. low-priority Low priority to be addressed.

Comments

@RyanTheAllmighty
Copy link
Member

RyanTheAllmighty commented Feb 9, 2022

Currently the launcher is pretty much only single task minded. If you launch Minecraft or instance an instance, you cannot do anything else.

Ideally I'd like it so when you install an instance, it kind of just works in the background.

That will probably only work once we get past the step of picking optional mods and we may also need to bring the browser mod downloads earlier and then once done, move it to downloading and installing in the background.

Also when launching an instance, it would be nice to just keep the launcher open if the user desires, so they can do things with the launcher.

To allow multiple instance launches this is likely going to require changes to the way the console works, since currently all MC logs go to the launchers console. Might need to make it so when you launch an instance, a new window pops up which allows logs to go there as well as adding the controls for killing the instance. Then begs the question, what happens with the launchers console. I don't really want to remove the launchers console as it's the single most useful thing for users to provide to fix issues. If it goes away or is harder to access, it's going to make my life hell trying to support people if it's too complex, so some thought needs to be put into that.

No idea if this will be possible, I'm sure it will, but within the launchers current codebase, I don't imagine it will be too straight forward, a lot of it was designed poorly to be single task minded.

@RyanTheAllmighty RyanTheAllmighty added enhancement Feature requests. high-priority High priority to be addressed. labels Feb 9, 2022
@TNTUP
Copy link

TNTUP commented Mar 31, 2022

If this gets implemented, I'd be sure moving to ATLauncher (should support multi-accounts right?)

@RyanTheAllmighty
Copy link
Member Author

Not sure what you mean by supporting multi-accounts, but it already supports multiple accounts

@TNTUP
Copy link

TNTUP commented Mar 31, 2022

Not sure what you mean by supporting multi-accounts, but it already supports multiple accounts

thats what I meant 🤣 I figured it out, sorry my english is quite bad XD

@RyanTheAllmighty RyanTheAllmighty added low-priority Low priority to be addressed. and removed high-priority High priority to be addressed. labels Jun 18, 2022
@s0cks
Copy link
Contributor

s0cks commented Jun 18, 2022

@RyanTheAllmighty
Make the launcher console invisible by default in production (available via setting or command line argument to users) and visible to developers in non production scenarios

Then make a console for each launched instance of Minecraft. You can use log4js markers to sort the logs between the consoles.

@Doomsdayrs
Copy link
Collaborator

@RyanTheAllmighty Make the launcher console invisible by default in production (available via setting or command line argument to users) and visible to developers in non production scenarios

This is a nightmare for power users, who know how to fix errors, and cuts them off entirely from working with the launcher in an in depth way.


Regarding multi launching, this requires a complete separation of UI from Data, as currently multiple instance imply IO conflicts.

What if one saves B and the other saves A, which one should be prioritized?

In summary, proper architecture is needed, upon that you need a central program that handles IO, IPC, ans event management between each instance.

@s0cks
Copy link
Contributor

s0cks commented Jun 18, 2022

This is a nightmare for power users, who know how to fix errors, and cuts them off entirely from working with the launcher in an in depth way.

How does it cut them off, it's still available to them?

@Doomsdayrs
Copy link
Collaborator

This is a nightmare for power users, who know how to fix errors, and cuts them off entirely from working with the launcher in an in depth way.

How does it cut them off, it's still available to them?

I revoke my statement, I misread as "hide in production"

@s0cks
Copy link
Contributor

s0cks commented Jun 18, 2022

I mean yes hide it by default but make it available to someone that wants it. If another console is going to present the Minecraft logs to the user then that one should be more visible than the launcher logs.

Maybe down the road make the app logs pop open when there's an error if it's hidden so there's visibility to the user.

@Doomsdayrs
Copy link
Collaborator

As of this comment, #617 makes the settings panel more multi threaded. Allowing multiple different checks to occur at once and having the UI react to them asynchronously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. low-priority Low priority to be addressed.
Development

No branches or pull requests

4 participants