Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

const-qualify FFT-related functions (as much as possible) #98

Open
escherstair opened this issue Mar 24, 2023 · 0 comments
Open

const-qualify FFT-related functions (as much as possible) #98

escherstair opened this issue Mar 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@escherstair
Copy link

escherstair commented Mar 24, 2023

I've been looking to some of the FFT-related functions and trying to find if some of them can be changed const-qualifying some of the input parameters.
I use a bottom-up apòproach (from the most internal to the high-level functions):
an I right if I think that in

/* Prepares data for inverse cfft */
void merge_rfft_f32(
const arm_rfft_fast_instance_f32 * S,
float32_t * p,
float32_t * pOut)
{

the input parameter float32_t * p can be const-qualified?

void merge_rfft_f32(
  const arm_rfft_fast_instance_f32 * S,
        const float32_t * p,
        float32_t * pOut)

At a first sight of source code, it seems that the pointed ddta is not changed.
Can someone of the devdelopers double check, please?

@christophe0606 christophe0606 added the enhancement New feature or request label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants