Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __WEAK attribute to DSP Functions #171

Open
renesas-kyle-finch opened this issue Apr 17, 2024 · 3 comments
Open

Add __WEAK attribute to DSP Functions #171

renesas-kyle-finch opened this issue Apr 17, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@renesas-kyle-finch
Copy link

There are some cases where we need to use our own implementations of some arm_* functions.

If these functions had the __WEAK attribute, this would be possible without needing to customize CMSIS-DSP on a case by case basis.

@christophe0606 christophe0606 added the enhancement New feature or request label Apr 18, 2024
@christophe0606
Copy link
Contributor

@renesas-kyle-finch May I ask which functions need to be customized ?
What are the needed changes ?

Perhaps those changes may be integrated in the original function.

@christophe0606 christophe0606 added the review Under review label Apr 18, 2024
@renesas-kyle-finch
Copy link
Author

@christophe0606 We have 32-bit multiply accumulator hardware in which we would like to use CMSIS DSP API functions that make use of our hardware registers within some of the DSP functions.

In our case, we have added __WEAK to the following functions:
arm_mult_q31
arm_scale_q31
arm_biquad_cascade_df1_q31
arm_conv_partial_q31
arm_conv_q31
arm_correlate_q31
arm_fir_decimate_q31
arm_fir_interpolate_q31
arm_fir_q31
arm_fir_sparse_q31
arm_lms_norm_q31
arm_lms_q31
arm_mat_mult_q31
arm_mat_scale_q31
arm_mat_vec_mult_q31

@christophe0606
Copy link
Contributor

@renesas-kyle-finch Thanks for feedback. So, indeed in this case __WEAK is the only solution.
I'll plan it for a future release.

@christophe0606 christophe0606 removed the review Under review label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants