Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-place filtering, complex computation #110

Open
Alouettesu opened this issue Jun 26, 2023 · 3 comments
Open

In-place filtering, complex computation #110

Alouettesu opened this issue Jun 26, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Alouettesu
Copy link

Alouettesu commented Jun 26, 2023

Can input and output arrays in filtering functions and complex math functions be same?

arm_fir_f32(&S, samples, samples, N);
arm_biquad_cascade_df2T_f32(&S, samples, samples, N);
arm_cmplx_mag_f32(samples, samples, numSamples);

If this is possible, it should be mentioned in documentation. If impossible, these arguments must be marked with restrict attribute.

@christophe0606 christophe0606 added the review Under review label Jul 3, 2023
@christophe0606
Copy link
Contributor

@Alouettesu It is on my to do list to review (and document) the functions where the output can be the input. And when the output can be the input, I'll create also a separate version with restrict keyword where the output and input must be different.

For complex mag, it is possible to do in place processing.
For the filtering I don't (yet) know.

@christophe0606 christophe0606 added enhancement New feature or request and removed review Under review labels Jul 3, 2023
@JustasSiauliai
Copy link

Hi Cristopher, did you have any chance to review this issue?

@christophe0606
Copy link
Contributor

@JustasSiauliai Unfortunately, documenting all of this is a change that will take a long time since there are lots of function to review and update.
The most secure is to assume you can't do in-place filtering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants