-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support up to Wagtail 5.2 #286
Conversation
…t for Wagtail <4.1
a728f7f
to
0b7e873
Compare
@leewesleyv |
@itbabu I was thinking of removing the Django dependency in its entirety, but wasn't sure if that would be the best way forward. The main aim here was to support both Wagtail LTS (5.2) and Django LTS (4.2), where Django was already supported. Hence why I only bumped Wagtail. I'd love to hear what you would recommend in terms of supported versions. |
Looking into the Wagtail Release schedule (https://github.com/wagtail/wagtail/wiki/Release-schedule), I see that: Wagtail 5.2 LTS is supported until 3 February 2025. Inspecting the Wagtail setup (https://github.com/wagtail/wagtail/blob/main/setup.py), I found that it requires:
Puput should support this range or a subset of it. Django 3.2 falls outside of this range, so it shouldn't be supported. Consequently, I would remove the Django requirement from Puput setup and keep only the Wagtail requirement.
|
@leewesleyv Additionally, the other requirements should be addressed: What are your thoughts? |
@itbabu Especially to what extend django-social-share and django-colorful are used, I think it would be a good decision to remove these dependencies. I will see if I can find a fitting replacement (code-wise) for where we use these, or have a clear migration path for people that are using these functionalities. |
…hey are no longer actively maintained
Merge please |
Hello @leewesleyv! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good with wagtail 5.2!!
Thanks for your time and patience.
There's one thing to add compatibility with wagtail6, but lets work it later on.
As the conflic it was because of me merging a dependabot PR, I've solved. |
Resolves #285