Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django Comments are now required #222

Open
loleg opened this issue May 16, 2020 · 3 comments
Open

Django Comments are now required #222

loleg opened this issue May 16, 2020 · 3 comments

Comments

@loleg
Copy link

loleg commented May 16, 2020

Currently the setup guide or comments chapter makes no mention of Django Comments - but I am getting this error from compress:

../lib/python3.7/site-packages/puput/templates/puput/comments/django_comments.html: 
'comments' is not a registered tag library

Adding it to my project (django.contrib.sites and django_comments in INSTALLED_APPS) according to the Quick Start resolves this.

@loleg
Copy link
Author

loleg commented May 18, 2020

Adding django.contrib.sites breaks things (like the admin panel, ahem..) in Wagtail, so this is not a good workaround. If anyone has other ideas of how to deal with this error, please let me know.

@michalpleszczynski
Copy link
Contributor

I've added an option to use django comments in #215, the documentation was updated in that PR as well, so it looks like it needs to be pushed to readthedocs? Anyway, I'll check out the error

@woesoe
Copy link

woesoe commented Apr 11, 2021

I would use the documentation of django-comments-xtd instead of django-comments if I were you. I Followed all the steps in the django-comments-xtd quick start guide (https://django-comments-xtd.readthedocs.io/en/latest/quickstart.html), added PUPUT_COMMENTS_PROVIDER = "puput.comments.DjangoCommentsProvider" in the Django Settings and got comments to work.

When I change django_comments.html like below, nested indenting doesn't work unfortunately. If anyone could help me with that it would be greatly appreciated.

{% load comments %}
{% load comments_xtd %}

<div>
    <h3>Comments:</h3>
    {% render_comment_form for entry %}
    {% render_xtdcomment_tree for entry%}
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants