New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FASW only takes into account SW of last two layers #2214

Open

BrianCollinss opened this issue Aug 8, 2023 · 2 comments

Member

BrianCollinss commented Aug 8, 2023 •

edited

FASW only takes into account the water content of the last two layers of the rooting profile.

Is this intentional?

https://github.com/APSIMInitiative/APSIMClassic/blob/2dc1d3475e340e45da473f1daf5e66e98f448361/Model/Plant/Root/RootPart.cpp#L351

https://github.com/APSIMInitiative/APSIMClassic/blob/2dc1d3475e340e45da473f1daf5e66e98f448361/Model/Plant/Root/RootPart.cpp#L362-L370

It is not the same in NextGen:

https://github.com/APSIMInitiative/ApsimX/blob/9fb534a9772c45e680b3d4f0d88eef6931e179b2/Models/PMF/Organs/Root.cs#L363

Member Author

BrianCollinss commented Aug 11, 2023

@hol353 Hi Dean. May I please have your comment on this?

Contributor

hol353 commented Aug 11, 2023

I didn't write the root organ class in Next Gen so I have no idea why Next Gen is different to 7.10 in its calculation of FASW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment