Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorghum fails to grow when LAI < 0.001 #1950

Open
peter-devoil opened this issue Nov 6, 2020 · 4 comments · May be fixed by #2125
Open

Sorghum fails to grow when LAI < 0.001 #1950

peter-devoil opened this issue Nov 6, 2020 · 4 comments · May be fixed by #2125
Labels
bug Something isn't working

Comments

@peter-devoil
Copy link
Collaborator

Low plant density combined with low temperature & radiation results in sorghum failing to grow. Higher plant density in the same environment does.

In the code, there is an incorrect limit placed on LAI that scrubs existing LAI.

Demonstration
@peter-devoil peter-devoil mentioned this issue Nov 6, 2020
Closed
@peter-devoil peter-devoil added the bug Something isn't working label Nov 6, 2020
@peter-devoil
Copy link
Collaborator Author

@jbrider - minor, but not insignificant changes. Biggest yield diff I saw was ~50kg.

@jbrider
Copy link
Contributor

jbrider commented Nov 6, 2020

That's good news then.
I did expect a few more files to be changed.

@peter-devoil
Copy link
Collaborator Author

I'm wondering if I can dig up one of those old simulations where the crop would linger (with next to zero leaf area) for 2 years before overflowing an array somewhere.

@peter-devoil
Copy link
Collaborator Author

I suspect some other code is broken by this patch. This sequence is from an early sowing in surat. It eventually grows to LAI > 3 even though it is 0 at one stage.

  7 August 2018(Day of year=219), sorghum: 
 Stage 2 Germination  DAS = 1
            Biomass       =   0.00           LAI            =   0.00
            Stover N Conc =   0.00           Extractable SW =   3.03
  16 August 2018(Day of year=228), sorghum: 
 Stage 3 Emergence  DAS = 10
            Biomass       =   0.00           LAI            =   0.00
            Stover N Conc =   0.00           Extractable SW =  22.39
  17 August 2018(Day of year=229), sorghum: 
 Frost Event: (Non Fatal) 
            Min Temp      = -0.21            Senesced LAI    = -0.01
  ...
  22 August 2018(Day of year=234), sorghum: 
 **Frost Event: (Fatal)** 
            Min Temp      = -5.11            Senesced LAI    = -0.01
  24 August 2018(Day of year=236), sorghum: 
 Frost Event: (Non Fatal) 
            Min Temp      = -2.56            Senesced LAI    = -0.01
  31 August 2018(Day of year=243), sorghum: 
 Frost Event: (Non Fatal) 
            Min Temp      = 0.43             Senesced LAI    = -0.00
  7 September 2018(Day of year=250), sorghum: 
 Stage 4 EndOfJuvenile  DAS = 32
            Biomass       =   2.39           LAI            =   0.02
            Stover N Conc =   0.08           Extractable SW = 115.81
  18 September 2018(Day of year=261), sorghum: 
 Frost Event: (Non Fatal) 
            Min Temp      = -1.15            Senesced LAI    = 0.14
  27 September 2018(Day of year=270), sorghum: 
 Stage 5 FloralInitiation  DAS = 52
            Biomass       =  20.38           LAI            =   0.33
            Stover N Conc =   0.61           Extractable SW = 128.87

@peter-devoil peter-devoil mentioned this issue Feb 5, 2021
Closed
peter-devoil referenced this issue in peter-devoil/APSIMClassic Feb 10, 2022
@peter-devoil
Remove low LAI threshold
31ff1b4
@peter-devoil peter-devoil linked a pull request Feb 10, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove low LAI threshold peter-devoil/APSIMClassic
2 participants
@jbrider @peter-devoil