Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change selection background color #143

Open
gayanper opened this issue Jun 15, 2021 · 3 comments
Open

Change selection background color #143

gayanper opened this issue Jun 15, 2021 · 3 comments

Comments

@gayanper
Copy link

gayanper commented Jun 15, 2021

The default yellow shade is two bright which make the text unreadable after selection. I'm currently using
#5E5B3C which gives a better contrast.

image

@gayanper gayanper changed the title Change selection background color on MacOS Change selection background color Jun 16, 2021
@gayanper
Copy link
Author

This is same on both MacOS and Windows

@AObuchow
Copy link
Owner

Thanks for reporting @gayanper .

This is related to #116.
Spectrum Theme's text selection on mac is objectively unusable, and I find your suggested color much more appropriate for Mac OS until the underlying upstream bug is resolved.

From a subjective standpoint, I like the current look on Linux/Windows, with a yellow background and black foreground:
image

This is same on both MacOS and Windows

However you said you find this issue also occurs on Windows, so we might differ in opinions on the yellow/black color choice, but that's ok :)

At the very least, I could add custom CSS for Mac's only to change the selection color to #5E5B3C as you suggested, What are your thoughts on doing that?

@gayanper
Copy link
Author

Hmm may be if this was decided intentionally may be i can change it and let oomph to sync over my workspaces. if you think the same let close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants