Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with colors on Project Facets window #127

Open
vamsigangarapu opened this issue Aug 19, 2020 · 16 comments
Open

Issue with colors on Project Facets window #127

vamsigangarapu opened this issue Aug 19, 2020 · 16 comments
Labels
bug Something isn't working Windows

Comments

@vamsigangarapu
Copy link

After applying the theme I noticed that the project facets window has white background with white text. So, its impossible to look at the text on the window.

@AObuchow
Copy link
Owner

@vamsigangarapu thanks for reporting :) Could you send a picture of the project facets view? I don’t think I’ve used it before :o

Will try to get this fixed soon for you :)

@vamsigangarapu
Copy link
Author

@AObuchow Here is the screen shot.
gIxb9

@AObuchow
Copy link
Owner

@vamsigangarapu thank you ! And you’re on Windows 10?

@vamsigangarapu
Copy link
Author

vamsigangarapu commented Aug 19, 2020

@AObuchow Yes, I am using Windows 10 with Eclipse version 2020-06. Also, I noticed similar behavior on Content Assist when Use Mixed Fonts and colors for Labels checkbox is checked in Preferences -> General -> Appearance.

@AObuchow AObuchow added bug Something isn't working Windows labels Aug 19, 2020
@AObuchow
Copy link
Owner

AObuchow commented Aug 19, 2020

@vamsigangarapu excuse my ignorance, but I'm actually unfamiliar with the projects facets window. Do you know if this come from some plugin you have installed? (I think I'm missing something, as I can't seem to find it when right-clicking a project -> proejct properties window).

@AObuchow
Copy link
Owner

@AObuchow Yes, I am using Windows 10 with Eclipse version 2020-06. Also, I noticed similar behavior on Content Assist when Use Mixed Fonts and colors for Labels checkbox is checked in Preferences -> General -> Appearance.

Thanks for the info :) Would you mind making a separate bug for this issue? With a photo ideally. I can test this on my Windows machine when I have a moment.

In both cases, do these bugs not occur with the normal Eclipse dark theme?

@vamsigangarapu
Copy link
Author

vamsigangarapu commented Aug 19, 2020

@AObuchow right-click on the project -> properties -> Project Facets. This behavior doesn't exist on Eclipse inbuilt dark theme

@AObuchow
Copy link
Owner

@vamsigangarapu I believe Project Facets comes from Eclipse WebTools . I can try and see if I can reproduce the issue after installing webtools, but know that Eclipse webtools is being replaced with Eclipse Wild Web Developer.

I'll keep you updated.

@vamsigangarapu
Copy link
Author

@AObuchow You can see Project Facets on a plain Java project as well. I have a Core Java project without any web components attached to the project. When I right click on the project in the project explorer window and went to properties I see Project Facets there. Initially it will ask us to convert the project when we hit convert it will show the above (Facets) window.

@AObuchow
Copy link
Owner

@vamsigangarapu thanks for the help :) I think however you have a plugin installed that I don’t have, as I don’t have a project facets option.

I’m installing JBoss tools right now, it contains many plugins and might have the right one to see the project facets options.

@AObuchow
Copy link
Owner

@vamsigangarapu After installing JBoss tools, I can see the projects facets options.
I think this is a Windows-specific bug, as on Linux, things seem to look OK:
image

I'll try to reproduce it on my Windows machine tomorrow and see if I can come up with a fix

@vamsigangarapu
Copy link
Author

@AObuchow Thank you for the prompt reply

@AObuchow
Copy link
Owner

@vamsigangarapu it might be related to https://bugs.eclipse.org/bugs/show_bug.cgi?id=563475, but I'm not sure. This has been fixed in Eclipse 4.17 which releases soon enough.

Do you mind posting a photo of the project faces look with the standard dark theme? Is it similar to this?

@vamsigangarapu
Copy link
Author

@AObuchow This is the Project Facets screen with Eclipse default Dark theme:
eclipse

@AObuchow
Copy link
Owner

AObuchow commented Sep 14, 2020

So the property page that is misbehaving is coming from org.eclipse.wst.common.project.facet.ui.internal.FacetsPropertyPage. Just writing this as a little note to myself... I still need to clone org.eclipse.wst

Sorry for the delay on having this fixed @vamsigangarapu

@vamsigangarapu
Copy link
Author

Sure, no problem. I have currently switched to the eclipse dark theme till the issue is fixed. So, I am good. Please let me know when it is fixed so that I can switch back to the spectrum theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Windows
Projects
None yet
Development

No branches or pull requests

2 participants