Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReturnData: remove protected data members #2348

Open
dweindl opened this issue Mar 5, 2024 · 0 comments
Open

ReturnData: remove protected data members #2348

dweindl opened this issue Mar 5, 2024 · 0 comments
Labels
c++ refactoring

Comments

@dweindl
Copy link
Member

dweindl commented Mar 5, 2024

Currently, ReturnData has a number of protected data members that are used as temporary storage for model quantities during collecting the output data. It's currently rather intransparent which values are used when. They also waste some memory.
I'd suggest to remove them and rather pass SimulationState through a couple of functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++ refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dweindl