You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the dictionary of data that relates to the results of processing is cobbled together from the objects that are returned by topostats.dnatracing.trace_image() in the procesing.dnatracing() function (see here.
topostats.dnatracing.trace_image() is itself returning a dictionary, but only a subset of these are being saved to HDF5.
Is everything needed if its not being saved to HDF5?
If not then its likely that we can simplify what is returned by topostats.dnatracing.trace_image() and assign it directly to the grain_trace_data[direction] dictionary.
The statistics component of the dictionary currently returned by trace_image() should be returned as a separate object as it is not saved to HDF5, rather it is saved to the tracing_stats[direction] dictionary for combining with the grain statistics and writing to CSV.
The text was updated successfully, but these errors were encountered:
Want me to try and address this during the nodestats tracing merger, or keep to the small commits in which it might be best to wait until after? It seems pretty big already.
And for clarity are you expecting 1 object for each thing - i.e. return (to_be_merged_with_grainstats_df, for_hdf5_dict, etc...)?
Currently the dictionary of data that relates to the results of processing is cobbled together from the objects that are returned by
topostats.dnatracing.trace_image()
in theprocesing.dnatracing()
function (see here.topostats.dnatracing.trace_image()
is itself returning a dictionary, but only a subset of these are being saved to HDF5.Is everything needed if its not being saved to HDF5?
If not then its likely that we can simplify what is returned by
topostats.dnatracing.trace_image()
and assign it directly to thegrain_trace_data[direction]
dictionary.Line 411 would then read...
...and
topostats.dnatracing
would need modifying so that only the following are returned as a dictionary...The
statistics
component of the dictionary currently returned bytrace_image()
should be returned as a separate object as it is not saved to HDF5, rather it is saved to thetracing_stats[direction]
dictionary for combining with the grain statistics and writing to CSV.The text was updated successfully, but these errors were encountered: