Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing io/{load,save}_pkl #792

Open
ns-rse opened this issue Feb 6, 2024 · 1 comment
Open

Consider removing io/{load,save}_pkl #792

ns-rse opened this issue Feb 6, 2024 · 1 comment
Labels
IO Input and Output Plotting Issues pertaining to the plotting class

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Feb 6, 2024

Does anyone pickle their plots?

If not I think we could safely remove io/save_pkl and io/load_pkl as they are only used to save plots and the pickle format is was flagged by the unstable ruff S403 rule as possibly insecure.

For now the rule has been explicitly disabled and the --preview option disabled.

It would be useful to know if anyone uses this functionality and if not we can remove unused code.
@ns-rse ns-rse added Plotting Issues pertaining to the plotting class IO Input and Output labels Feb 6, 2024
ns-rse added a commit that referenced this issue Feb 6, 2024
@ns-rse
Explicitly disable ruff S403; disable ruff preview rules
222fc4f 
See #792 for further details.
ns-rse added a commit that referenced this issue Feb 6, 2024
@ns-rse
Explicitly disable ruff S403; disable ruff preview rules
78050b3 
See #792 for further details.
@ns-rse
Copy link
Collaborator Author

ns-rse commented Feb 19, 2024

See also #802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
IO Input and Output Plotting Issues pertaining to the plotting class
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ns-rse