Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total number of records are missing from all pagination APIs #2855

Open
ShahanaFarooqui opened this issue May 14, 2024 · 0 comments
Open

Total number of records are missing from all pagination APIs #2855

ShahanaFarooqui opened this issue May 14, 2024 · 0 comments

Comments

@ShahanaFarooqui
Copy link

Total number is records is a crucial information in order to successfully implement pagination in the UI but it is missing from all API responses currently. Below is the list of API which are accepting count and skip in request but do not return total number of records in the response:

ShahanaFarooqui added a commit to Ride-The-Lightning/RTL that referenced this issue May 14, 2024
Done most of the UI changes to accommodate pagination on transactions, payments and invoices tables but true pagination cannot be implemented till total number of records are missing from the API response.

Once the issue ACINQ/eclair#2855 is fixed, I will uncomment pagination changes in the frontend.
ShahanaFarooqui added a commit to Ride-The-Lightning/RTL that referenced this issue May 14, 2024
Done most of the UI changes to accommodate pagination on transactions, payments and invoices tables but true pagination cannot be implemented till total number of records are missing from the API response.

Once the issue ACINQ/eclair#2855 is fixed, I will uncomment pagination changes in the frontend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant