Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actor paths + deadletters instead of Register #1370

Open
pm47 opened this issue Apr 8, 2020 · 1 comment
Open

Use actor paths + deadletters instead of Register #1370

pm47 opened this issue Apr 8, 2020 · 1 comment

Comments

@pm47
Copy link
Member

pm47 commented Apr 8, 2020

We're not using actor paths in the code base, instead we pass around actor references. Btw I'm not sure if that's really a best practice, given that in theory we should let them crash which would invalidate their reference.

Instead, we're using the Register which keeps a map of channeld/shortChannelId/nodeId -> ActorRef.

I believe we could instead optimistically use actor paths, and catch unhandled messages in order to send back the appropriate error to the sender. See https://stackoverflow.com/a/23911129.

Might be simpler? Needs prototyping...

@t-bast
Copy link
Member

t-bast commented Oct 12, 2020

As discussed in other threads, it looks like the best practice with Akka Typed is using the Receptionist model (https://doc.akka.io/docs/akka/current/typed/actor-discovery.html), we will probably move to that at some point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants