Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions and suggestions following the results #40

Open
carpben opened this issue Apr 13, 2018 · 0 comments
Open

Questions and suggestions following the results #40

carpben opened this issue Apr 13, 2018 · 0 comments

Comments

@carpben
Copy link

carpben commented Apr 13, 2018

This is very helpful.

  1. However, I couldn't understand from the Readme file what React application (which we style with Css In Js) is the basis for the comparison.
  2. According to https://reactjs.org/docs/faq-styling.html#are-inline-styles-bad and also https://www.ctheu.com/2015/08/17/react-inline-styles-vs-css-stupid-benchmark/ CSS is more efficient than inline-Style. However, surprisingly, the results show contrary results:
    a. react (with inline-styles) is in the second row.
    b. styled-jsx-inline-styles - is third
    c. Glam Inline Style - also gets a high result.
    Is there any explanation for this somewhat unexpected results?
  3. Perhaps it would be helpful to add to the comparison table a column of the generated file size. This measurement dramatically effects the time it takes to the app to first load.
@carpben carpben changed the title It's not clear from the Readme what application is the basis for the comparison Questions and suggestions following the results Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant