fix: handle babel-preset-env 7.4.3 #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`babel-preset-env@7.4.3` has changed the format of how default exports are generated. This change makes sure the tests pass with the dependency upgraded. closes 59naga#73
TheLudd
force-pushed
the
fix-for-latest-babel
branch
from
25626f3
to
d5ed346
Compare
|
Duplicate of #70. |
lijunle
approved these changes
Apr 6, 2019
|
#70 is better with some unit tests. |
|
@lijunle Sure, the case with mine is that the dependency was upgraded and existing tests failed so I made them pass again |
|
I don't think #70 is fixing the existing unit tests. It is adding new unit tests to cover the new case. |
|
Please reopen this, in case the maintainer ever comes back. |
|
As mentioned, there is already another PR open that solves the issue, in exactly the same way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
babel-preset-env@7.4.3has changed the format of how default exportsare generated. This change makes sure the tests pass with the dependency
upgraded.
closes #73