-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to drag the drawer on iOS 14 #400
Comments
We had a very similar issue under iOS 12. An identical issue occurred with iOS 14 (weirdly enough it only occurred in distribution builds which was a nightmare to debug). In both cases it had to do with the internal scrollView of the PulleyViewController. It occurred when the contentHeight had decimal places. I do not recall exactly what was causing the endless layout cycles, but they occurred when the contentHeight was 1/3 px larger or smaller than the bounds of the scrollView - something like this. Anyway, long story, short suggestion:
Hope that fixes the issue for you, too. |
@dxt So I have found the issue and am working on a fix for it now. This issue is in iOS 14 updating constant on the constraint for the temperature label is calling
|
Thank you @JensDee for the suggestion. And thank you @ulmentflam for the fix! It is much appreciated! |
When compiled on Xcode 12 and run on an iOS 14 device, I am unable to drag the Pulley drawer to open or close it. Swiping works fine.
Here are examples on the Demo project:
Works on iOS 13
Does not work on iOS 14
This was on Pulley version 2.8.4. The same issue occurs on the iPad.
I traced through the code and found that, in iOS 14, in PulleyViewController,
viewDidLayoutSubviews()
is called every time afterscrollViewDidScroll(_:)
is called. That does not happen on iOS 13.Also, commenting out the line
setDrawerPosition(position: drawerPosition, animated: false)
inviewDidLayoutSubviews()
does bring back the dragging capability, but I doubt that's the right solution.Happy to provide more information if needed.
The text was updated successfully, but these errors were encountered: