Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with drawer not moving up when content is too tall #374

Open
jacobwhite opened this issue Jan 23, 2020 · 9 comments
Open

Issue with drawer not moving up when content is too tall #374

jacobwhite opened this issue Jan 23, 2020 · 9 comments

Comments

@jacobwhite
Copy link

I have a tableview inside the drawer, and when that table view has enough rows that its larger than the screen the drawer won't pull up. Instead what happens is that the drawer content will scroll within the drawer.

@amyleecodes
Copy link
Contributor

The sample project does this, and works properly. Please look for differences between your project and the sample project.

@jacobwhite
Copy link
Author

I don't think they could be more different lol, I'm using obj-c and not storyboards.

@amyleecodes
Copy link
Contributor

amyleecodes commented Jan 23, 2020

Anything in a storyboard can be done in code. I would compare the setup / view hierarchy and see what’s different.

@jacobwhite
Copy link
Author

jacobwhite commented Jan 24, 2020 via email

@amyleecodes
Copy link
Contributor

That’s probably why. I really don’t recommend putting Pulley inside of a table view. That’s a very odd UI pattern, aside from usability issues of scrolling inside of something scrollable.

@jacobwhite
Copy link
Author

Pully isn't inside a tableview, its a tableview inside the drawer.

@amyleecodes
Copy link
Contributor

Sorry, I misread your last comment.

The sample project has a table view in the drawer and it works fine. Most people’s uses have tableviews in the drawer and it works fine for them. Storyboard doesn’t matter.

Make sure you’re not doing things with gesture recognizer delegates, etc. or you could be breaking UIKits automatic handling of it.

@jacobwhite
Copy link
Author

No worries, I appreciate your responses. So I just changed my drawer to have instead of just a tableview, a view with a static view at the top, and a tableview below it. And now the tableview doesn't scroll! LOL.

Thanks for the feedback, I'll try to go back to the demo project and try to make sense of what it does and what I'm doing wrong.

Thanks again!

@jacobwhite
Copy link
Author

I got it, my scroll view was too big and not scrolling. Not sure if I fixed it the right way, but it seems to be working for me now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants