Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have last row expand to fill leftover width #13

Open
alashow opened this issue Mar 11, 2016 · 5 comments
Open

Have last row expand to fill leftover width #13

alashow opened this issue Mar 11, 2016 · 5 comments

Comments

@alashow
Copy link

alashow commented Mar 11, 2016

Hello.

Is it possible to add feature to fill full width on the last row? Without leaving blank space?

Blank spaces are okay when it's used in simple way (just recyclerView itself), but I want to use it as another recyclerView item, i.e main recyclerView items are recycylerViews with greedoLayoutManager.

Example usage case could be, photosets for post. Post is item of main recyclerView, and photoset is inner recyclerView with greedoLayoutManager.

Screenshots

First one is okay, but not second.

@JVillella
Copy link
Contributor

Hey @alashow. I'm not entirely sure if I understand your question. Is it that you want to have the layout take the total available height? In other words, have an auto max row width that determines the correct value to fill the entire view height. Or is it that you want a justified width, so that the last row (e.x. with your second screenshot) will adjust the height so that it fits the entire width while maintaining the aspect ratio?

@alashow
Copy link
Author

alashow commented Mar 29, 2016

Or is it that you want a justified width, so that the last row (e.x. with your second screenshot) will adjust the height so that it fits the entire width while maintaining the aspect ratio?

Yes, it's exactly what i want. Is it possible?

@JVillella
Copy link
Contributor

@alashow not currently unfortunately! This could be a useful feature to add though.

@JVillella JVillella changed the title Fill full height feature Have last row expand to fill leftover width Mar 29, 2016
@alashow
Copy link
Author

alashow commented Jun 8, 2016

@JVillella, any updates on this?

BTW, what if the last row have more than one image?
My goal is to not leave empty spaces when more width is available.

@indriks
Copy link

indriks commented Jan 19, 2017

@JVillella @alashow This feature is built and have pull request.
Alternatively, @alashow you can get it here https://github.com/indriks/greedo-layout-for-android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants