Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to register upgrade steps in multiple directories #226

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow to register upgrade steps in multiple directories #226

wants to merge 2 commits into from
+34 −7

Conversation

ale-rt
Copy link
Contributor

@ale-rt ale-rt commented Jun 29, 2022 •
edited

It allows to specify upgrades in multiple folders:

    <upgrade-step:directory
        profile="my.package:default"
        directory="v1"
        />
    <upgrade-step:directory
        profile="my.package:default"
        directory="v2"
        />

Fixes #217

@ale-rt ale-rt mentioned this pull request Jun 29, 2022
Open
@ale-rt
Copy link
Contributor Author

ale-rt commented Jul 19, 2022

CC @buchi @njohner

@ale-rt
Copy link
Contributor Author

ale-rt commented Sep 9, 2022

@lukasgraf @buchi @njohner any chance to have this checked?

@njohner
Copy link
Contributor

njohner commented Sep 13, 2022

Sorry for the delay. The feature is certainly good and the implementation LGTM, but you'd need to add a test.

Also for info, I made a PR from your branch so that tests are run (#228) and all tests are green.

@ale-rt
Copy link
Contributor Author

ale-rt commented Sep 13, 2022

As mentioned in #217 (comment) I tried to add some tests with ftw.builder but I had some troubles.
I will try again!

@ale-rt ale-rt mentioned this pull request Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support upgrade steps in subdirectories
2 participants
@ale-rt @njohner