With all-sites, some errors are not visible

[mauritsvanrees]

I tried this on a client project:

$ bin/upgrade install --all-sites --upgrades 5@zindex.website:default

The exit code ($?) was 1, so there was an error somewhere, but nothing was visible here, nor in the instance log. So I try it verbose:

$ bin/upgrade install --all-sites --verbose --upgrades 5@zindex.website:default
DEBUG urllib3.connectionpool: Starting new HTTP connection (1): localhost
DEBUG urllib3.connectionpool: http://localhost:8080 "GET /upgrades-api/list_plone_sites HTTP/1.1" 200 98
DEBUG urllib3.connectionpool: Starting new HTTP connection (1): localhost
DEBUG urllib3.connectionpool: http://localhost:8080 "POST /z-index/upgrades-api/execute_upgrades?upgrades%3Alist=5%40zindex.website%3Adefault HTTP/1.1" 400 135

Still an error, still nothing visible.
Then I specify a single Plone Site id (there is only one), and then I see a clear error:

$ bin/upgrade install --site z-index --upgrades 5@zindex.website:default
ERROR: Plone site outdated: The Plone site is outdated and needs to be upgraded first using the regular Plone upgrading tools.
> http://localhost:8080/z-index/upgrades-api/execute_upgrades?upgrades%3Alist=5%40zindex.website%3Adefault
< 400 Plone site outdated

So a specific site id (or --pick-site or --list-site) shows the error, but --all-sites does not show me anything.
Would this be fixable?

[deiferni]

At first glance it seems that with --all-sites sys.stdout is captured 🤔. See

ftw.upgrade/ftw/upgrade/command/__init__.py

Lines 155 to 165 in a0f6ee9

	with capture() as out:
	args.func(args)
	output = out.getvalue().strip()
	if getattr(args, 'json', False):
	# "[]" must be turned into [] and put in dictionary.
	output = json.loads(output)
	info[args.picked_site] = output
	else:
	logger.info('Acting on site {0}'.format(
	args.picked_site))
	print(output)

. Maybe something in there is not working as intended?

Side-note: In case of only one plone site i personally would recommend --pick-site or the -S shorthand as that will fail if it unexpectedly encounters more than one site.