Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl parser should return null if sql compile failed #3890

Open
vagetablechicken opened this issue Apr 24, 2024 · 0 comments
Open

ddl parser should return null if sql compile failed #3890

vagetablechicken opened this issue Apr 24, 2024 · 0 comments
Assignees
@vagetablechicken
Labels
bug Something isn't working

Comments

@vagetablechicken
Copy link
Collaborator

OpenMLDB/src/base/ddl_parser.cc

Line 122 in e1369fb

engine->Get(sql, used_db, session, status);

We should check return value and status. Even the sql compile failed, the map index_hints may still have some index hints.

And it effect OpenMLDBSQLEmulator, release a new version, v1.1-beta
@vagetablechicken vagetablechicken added the bug Something isn't working label Apr 24, 2024
@vagetablechicken vagetablechicken self-assigned this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vagetablechicken vagetablechicken

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vagetablechicken