Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImagePreview组件lazyload prop不生效？ #678

Open
1 of 2 tasks
cycyewt opened this issue Sep 6, 2023 · 0 comments
Open
1 of 2 tasks

ImagePreview组件lazyload prop不生效？ #678

cycyewt opened this issue Sep 6, 2023 · 0 comments
Labels
🕵️‍♂️ bug Something isn't working 🙋 pr welcome Welcome pr for this feature!

Comments

@cycyewt
Copy link

cycyewt commented Sep 6, 2023 •
edited

Which React Vant packages are impacted?

  • react-vant (React Vant core)
  • react-vant-icons(React Vant Icon)

What version of React Vant are you using?

latest

Reproduce live demo(codesandebox or stackblitz)?

No response

Descripition

从源码看，ImagePreview组件内部没有使用LazyImage，还是有其他机制实现？

react-vant/packages/react-vant/src/components/image-preview/slide.tsx

Line 166 in 309fb2a

<img

@3lang3 3lang3 added 🕵️‍♂️ bug Something isn't working 🙋 pr welcome Welcome pr for this feature! labels Sep 18, 2023
nieyunliang added a commit to nieyunliang/react-vant that referenced this issue Apr 7, 2024
@nieyunliang
fix: bug 3lang3#678
599c750
nieyunliang added a commit to nieyunliang/react-vant that referenced this issue Apr 8, 2024
@nieyunliang
Revert "fix: bug 3lang3#678"
bd00972 
This reverts commit 599c750.
nieyunliang added a commit to nieyunliang/react-vant that referenced this issue Apr 8, 2024
@nieyunliang
fix: bug 3lang3#678
214bce2
3lang3 pushed a commit that referenced this issue Apr 8, 2024
@nieyunliang
fix: bug #678 (#713)
d47a767 
* fix:  bug #678

* Revert "fix:  bug #678"

This reverts commit 599c750.

* fix:  bug #678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🕵️‍♂️ bug Something isn't working 🙋 pr welcome Welcome pr for this feature!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cycyewt @3lang3