Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant argument from package.json scripts #748

Open
prajwalkulkarni opened this issue Jan 18, 2024 · 2 comments · May be fixed by #749
Open

Remove redundant argument from package.json scripts #748

prajwalkulkarni opened this issue Jan 18, 2024 · 2 comments · May be fixed by #749

Comments

@prajwalkulkarni
Copy link
Contributor

Description
Currently, there are different webpack config files for different modes (dev/prod) with the base config file being webpack.common.js. The modes are mentioned in the corresponding config files (development/production). However, the modes are again explicitly passed when running scripts like build:dev,build:prod. I think this is not necessary and adds to redundancy. We can simply remove the --mode argument from build:dev and build:prod command.
Reference: Webpack mode
@dkoes
Copy link
Contributor

dkoes commented Jan 18, 2024

Please provide a pull request with your suggested changes.

@prajwalkulkarni prajwalkulkarni linked a pull request Jan 18, 2024 that will close this issue
Open
@prajwalkulkarni
Copy link
Contributor Author

@dkoes PR #749 addresses this issue. Kindly check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant argument from package.json prajwalkulkarni/3Dmol.js
2 participants
@dkoes @prajwalkulkarni