Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why did you add a negative sign to the position of camera? #37

Open
thucz opened this issue Mar 5, 2024 · 1 comment
Open

Why did you add a negative sign to the position of camera? #37

thucz opened this issue Mar 5, 2024 · 1 comment

Comments

@thucz
Copy link

thucz commented Mar 5, 2024

The code in https://github.com/3DTopia/LGM/blob/main/core/provider_objaverse.py#L166:

 cam_pos = - cam_poses[:, :3, 3] # [V, 3]

I cannot understand why you added a negative sign here.

@ashawkey
Copy link
Collaborator

@thucz Hi, you may check this: #15
This is the way that I found rendering to be correct... you can experiment on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants