Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-populated search field #18

Open
1 task done
sn00py1310 opened this issue Apr 22, 2022 · 2 comments
Open
1 task done

Pre-populated search field #18

sn00py1310 opened this issue Apr 22, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@sn00py1310
Copy link

Information about the feature to be added:

Sometimes I show some friends this site when they ask me about 2fa for a specific website. A much easier way would be a pre-populated search field, so they find the information faster. It could also be handy for links from another website.

This could be done client side:

// https://2fa.directory/int/?q=github
let search_field = new URLSearchParams(window.location.search).get('q');
@sn00py1310 sn00py1310 added the enhancement New feature or request label Apr 22, 2022
@phallobst
Copy link
Member

We currently have an auto-redirect that might conflict with this feature. For example, if I clicked on https://2fa.directory/?q=harvard (from Germany), it would result in the target URL https://2fa.directory/de/ with the search term "harvard" - and will get no results. Maybe we might be able to disable the auto-redirection when a search term is present. The workaround would be to use the "int" (or any other suitable) region for these links, i.e. https://2fa.directory/int/?q=harvard or https://2fa.directory/us/?q=harvard

@sn00py1310
Copy link
Author

The country filtering is a good part of the UX, so why change the known behavior. And there is already the region notice. So a basic implementation for the search should be suitable. But I'm open-minded to other opinions.

@Carlgo11 Carlgo11 transferred this issue from 2factorauth/twofactorauth Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants