This repository has been archived by the owner on Aug 27, 2019. It is now read-only.
Fix sm #66
Closed
Fix sm #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major refactor to break out .run method and create new helper class
…ss properties and move orderlist to waterfall
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the functionality to fix #8 (which is not totally working yet.) Also, reimplement some of the global scoped
classthisto make class properties accessible to the methods even when they get called deeply in a promise.Because of the class property access difficult, what gets stubbed in the test for
closedUsedStagesis the opposite of what is needed to actually run the method in the class.