Skip to content
This repository has been archived by the owner on Dec 25, 2020. It is now read-only.

develop authority mock up #42

Open
nikzei opened this issue Mar 16, 2020 · 3 comments
Open

develop authority mock up #42

nikzei opened this issue Mar 16, 2020 · 3 comments
Assignees

Comments

@nikzei
Copy link

nikzei commented Mar 16, 2020

We have a basic list of features that we believe would be great to add once we're done building our initial "small slice" for GSA (see in our mural roadmap).

Let's start making mocks of them for the purpose of communicating these features to stakeholders. We can use our synth outcomes to steer this work.

@nikzei nikzei created this issue from a note in Phase three work (To do) Mar 16, 2020
@ondrae ondrae moved this from To do to In progress in Phase three work Mar 19, 2020
@nikzei nikzei changed the title mock up more features develop authority mock up Mar 23, 2020
@igorkorenfeld
Copy link
Member

I have made adjustments to some of the colors based on my research into the GSA website and in wanting to adjust some of the visual style. I can make updates to the the CSS to reflect in the design.

Adding in an authority a link to the statute:
PrvOps_Authority

For multiple authorities:
PrvOps_MultipleAuth

If we are not able to strip out the additional prose, we may consider just adding in the paragraph from the PIA. If they starting getting long, it might be worth considering make it into a show/hide text or an expandable.
PrvOps_Authority_Long

@ondrae
Copy link
Collaborator

ondrae commented Mar 27, 2020

I was digging around in the Federal Register code and found how they dynamically link to the correct federal law web pages!

Here is the code to find when a law is mentioned. https://github.com/usnationalarchives/federalregister-web/blob/1694d1c494f7733ddddcaa90eb906851ee8803ae/app/models/citation.rb

Here is the code to build a link from it.
https://github.com/usnationalarchives/federalregister-web/blob/1694d1c494f7733ddddcaa90eb906851ee8803ae/lib/route_builder/external_urls.rb

@igorkorenfeld
Copy link
Member

This is awesome! I noticed there are a couple of characters that's it's not handling well the em dash (—) and the section sign (§). Other than that it's looking great

@peterrowland peterrowland moved this from In progress to Done in Phase three work Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

No branches or pull requests

3 participants