Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute back to Pwntools #13

Open
zachriggle opened this issue Jan 12, 2021 · 1 comment
Open

Contribute back to Pwntools #13

zachriggle opened this issue Jan 12, 2021 · 1 comment
Assignees

Comments

@zachriggle
Copy link

You've got a lot of really great ideas implemented here, it would be really cool if you could try to port them to Pwntools and open some Pull Requests!

@152334H
Copy link
Owner

152334H commented Jan 12, 2021

The biggest barrier to me doing precisely that has always been the presence of pre-existing code I don't want to disturb / think about. Obvious offenders here are the already-existing pwnlib.libcdb & pwnlib.FmtStr modules.

It's not like I haven't thought about it often. There are parts of this repo (see pwnscripts/context.py) that would've been really easier to implement upstream...

...and you know, I wanted to try that with the ROP Pull Request a while back. I ended up calling that one quits because I fundamentally disagreed with the suggested changes, but I also felt that it'd be wrong or counterfactual to brazenly disagree with someone that's sunk in a few hundred thousand lines in commits.

Shifting the work I've done here upstream at some point is essentially inevitable. Keeping up with all of the monkeypatching I have to do to keep pwnscripts alive is something I'm not very keen on maintaining. At the same time, I don't want to see my own designs here butchered in some quick hacky port of half the features to pwntools proper.

You'll be seeing a number of pull requests from me eventually --- just not right now.

@152334H 152334H self-assigned this Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants