Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with List pagination #14

Open
vignejerome opened this issue Dec 17, 2017 · 1 comment
Open

Problem with List pagination #14

vignejerome opened this issue Dec 17, 2017 · 1 comment

Comments

@vignejerome
Copy link

Hello,

I have a javascript error with a list pagination. I have 4 list in one page :
TypeError: window.listUpdated is not a function
at Array.callback (?preview_id=22920&preview_nonce=63a60ef3ec&_thumbnail_id=-1&preview=true:2234)
at i.trigger (list.min.js:1)
at i.update (list.min.js:1)
at i.show (list.min.js:1)
at HTMLLIElement. (list.pagination.min.js:1)

have you ever encountered problem ?

Thx

@elysium001
Copy link

I have also encountered this problem and appears to happen if I have the "delete entries" option off.

I believe lines 700 and 708 of the class-sticky-list.php need to have a null checker for the callback functions.

I updated my copy to this and it seemed to work... Probably a better way to handle this though. Also, I only tested on latest FireFox and Chrome.

function callback() { return window.listUpdated instanceof Function ? window.listUpdated():''; }

Please let me know if I can help with a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants