Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCS linting failures #295

Open
1 task done
dkotter opened this issue Dec 14, 2023 · 0 comments
Open
1 task done

PHPCS linting failures #295

dkotter opened this issue Dec 14, 2023 · 0 comments
Assignees
Labels
help wanted type:bug Something isn’t working.
Milestone

Comments

@dkotter
Copy link
Collaborator

dkotter commented Dec 14, 2023

Describe the bug

Noticed with recent merges to develop and trunk that we are getting some PHPCS errors. When merging into either of those branches, we lint all files, not just changed files. So we're not getting failures on individual PRs but we are getting failures on those branches.

Looking at the last failed report, seems all the issues have to do with our Compat Validation Tool. Ideally these issues are addressed within that repo but I think we should adjust our PHPCS rules to exclude that directory from linting, as we shouldn't lint dependencies.

Steps to Reproduce

Locally run composer install and then ./vendor/bin/phpcs .. You should see PHPCS issues with test files and with dependency files. Both should be excluded

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dkotter dkotter added the type:bug Something isn’t working. label Dec 14, 2023
@dkotter dkotter added this to the 7.6.0 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type:bug Something isn’t working.
Projects
Status: To Do
Development

No branches or pull requests

3 participants