Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status report page #3910

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

furai
Copy link
Contributor

@furai furai commented May 13, 2024

Description of the Change

Fixes the bug with status report page throwing an error when indexable post types returns an empty array.
Closes #3909

How to test the Change

Add ep_indexable_post_types filter that returns an empty array.

Changelog Entry

Fixed - Status report page when indexable post types is an empty array.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@furai
Copy link
Contributor Author

furai commented May 13, 2024

I'll check if I can cover this in a test case and edit the main post accordingly.

EDIT: I could probably do it but definitely not today. I've been looking into whole setup and it's a bit complicated for a new contributor like me. I'd appreciate if any contributor could chime in and maybe add these extra tests if required for me. Maybe it's possible to merge this PR without extra tests cause it's really minor patch.

@felipeelia felipeelia added this to the 5.1.1 milestone May 24, 2024
@felipeelia felipeelia merged commit 2b95db0 into 10up:develop May 24, 2024
16 of 20 checks passed
@felipeelia
Copy link
Member

Thanks for the PR @furai!

@furai furai deleted the feature/fix-status-report-page branch May 24, 2024 20:02
@furai
Copy link
Contributor Author

furai commented May 24, 2024

Thank you! I found some other issues I might patch in future. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Status report page breaks when ep_indexable_post_types returns empty array
2 participants