Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

sol-cov: suggested performance improvement. #1891

Open
drortirosh opened this issue Jun 25, 2019 · 1 comment
Open

sol-cov: suggested performance improvement. #1891

drortirosh opened this issue Jun 25, 2019 · 1 comment

Comments

@drortirosh
Copy link

Expected Behavior

Current Behavior

sol-coverage is currently very slow to run: it is required to re-execute each transaction in debug in order to collect coverage data.

Tests that normally takes ~200ms to run nows over 1-2 seconds when collecting coverage data.
While its OK for periodically coverage runs, it prevents from adding the coverage results added to every unit-test running.

Possible Solution

Instead of re-submitting the transcation, a hook can be added into ganache, to report ALL EVM instruction addresses.
This means a normal (test) run is executed, and in parallel, coverage data is collected.
Then, after the run is complete, a single run of the "instanbul" reporting tool will genreate the text/html report.

@stale
Copy link

stale bot commented Jul 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 25, 2019
@fabioberger fabioberger added pinned and removed stale labels Jul 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants