Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

monorepo: CircleCI should show test results of a prospective merge #1877

Open
xianny opened this issue Jun 18, 2019 · 1 comment
Open

monorepo: CircleCI should show test results of a prospective merge #1877

xianny opened this issue Jun 18, 2019 · 1 comment

Comments

@xianny
Copy link
Contributor

xianny commented Jun 18, 2019

Expected Behavior

CircleCI should show test results of a prospective merge. A PR shouldn't "pass" unless the proposed merge also passes.

Current Behavior

Given a PR proposing a merge of compare into base, CI only shows results of the compare branch on its own, ignoring the base branch. If the compare branch has not recently merged base into itself, then CI could pass a PR that causes base to start failing.

Possible Solution

It looks like CircleCI is the only CI/CD tool that doesn't support this out of the box. We can try this workaround: https://discuss.circleci.com/t/show-test-results-for-prospective-merge-of-a-github-pr/1662/14

@stale
Copy link

stale bot commented Jul 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 26, 2019
@fabioberger fabioberger added pinned and removed stale labels Jul 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants